Wireshark-dev: Re: [Wireshark-dev] Petri Dish update
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Peter Wu <peter@xxxxxxxxxxxxx>
Date: Wed, 26 Nov 2014 00:02:07 +0100
On Tuesday 25 November 2014 23:37:26 Pascal Quantin wrote:
> 2014-11-25 18:59 GMT+01:00 Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>:
> > For information,
> > I have add the check of last commit
> > the Ubuntu Petri Dish buildbot launch a ./tools/pre-commit HEAD^1
> > (launch check[APIs|hf|filenames] on tested commit)
> >
> > It is possible to have same "false" postive warnings errors....
>
> unfortunately (as expected) it can trigger some false positives making
> Petri Dish fail (like for example
> http://buildbot.wireshark.org/petri-dish/builders/Ubuntu%20x86-64%20Petri%20Dish/builds/813/steps/Pre-commit%20check/logs/stdio
> even if this one could be questionable). I know that the script can choke
> on some ASN.1 auto generated dissectors. Maybe we are not ready for this
> yet...

Is it possible to make the buildbot add a Code-Review -1 instead of
setting the Verified flag for pre-commit failures?
-- 
Kind regards,
Peter
https://lekensteyn.nl