On Thu, Nov 20, 2014 at 5:09 AM, Evan Huus <eapache@xxxxxxxxx> wrote:
> This is awesome Alexis, thank you!
>
> On Wed, Nov 19, 2014 at 4:40 PM, <mmann78@xxxxxxxxxxxx> wrote:
>> So for the Windows build is there nmake + cmake or cmake only? I thought I
>> saw some Petri-Dish runs with failed (cmake) Windows builds, but then some
>> others with successful (cmake?) builds. So is cmake fully functional for
>> Windows now?
>
> Looks to me like cmake and nmake are both run, and both functional.
Yes, Windows Petri Dish run cmake and nmake
>
>> Is Petri Dish is going to be the only "user" that change the Verified field?
>
> I'm not sure if we need to go that far or not. We can definitely
> require a Verified+1 in order to merge, but it may still be useful to
> be able to manually verify changes. We don't have to decide right away
> regardless - let's discuss once the petri-dish is complete and we've
> run with requiring +1-verified for a while to see.
>
>> How are we going to notate tested patch functionality fails? Just a
>> "review" -1? I have liked the distinction between "good/bad code" (passing
>> code review) vs tested/failed code that I've seen used on various
>> submissions.
Actually, the Verified flag is no often use... i think, it is better
to have this flag set by automated tests (My Opinion...)
>>
>>
>>
>> -----Original Message-----
>> From: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
>> To: Developer support list for Wireshark <wireshark-dev@xxxxxxxxxxxxx>
>> Sent: Wed, Nov 19, 2014 3:35 pm
>> Subject: [Wireshark-dev] Petri Dish update
>>
>> Hi,
>>
>> Some news about last update on Petri Dish !
>>
>> Linux/Ubuntu
>> * devscript is now installed on AMI and i have add licencecheck step :-)
>>
>> Windows :
>> * Add CMake build (in cmbuild folder)
>>
>> TODO :
>> * Fix testsuite test (Linux and Windows)
>> * Switch to x64 (Windows)
>> * Add a check of last commit for tools (like pre-commit hooks)
>> * Enable by default Verified+1 (and only Petri Dish can add Verified +1)
>>
>>
>> For check of last commit, i need some help (if there is some body with
>> bash skill, i think add a arg to pre-commit to launch git command like
>> git diff --name-only HEAD~1..HEAD)
>>
>> Do you have some request ?
>> ___________________________________________________________________________
>> Sent via: Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
>> Archives: http://www.wireshark.org/lists/wireshark-dev
>> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>> mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
>>
>>
>> ___________________________________________________________________________
>> Sent via: Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
>> Archives: http://www.wireshark.org/lists/wireshark-dev
>> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>> mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
> ___________________________________________________________________________
> Sent via: Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
> Archives: http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
> mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
