Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] master 1119eb6: generate ALIGN_TO_x_BYTE
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
Date: Thu, 6 Nov 2014 15:02:07 +0100
On Thu, Nov 6, 2014 at 1:09 PM,  <mmann78@xxxxxxxxxxxx> wrote:
> This and the subsequent commit (61676733b451bc8b3a83dee47df71c5ffe3f19dd)
> that regenerated all of the DCE/RPC dissectors doesn't pass the "eye test"
> to me.  The newly generated code now has a lot of what appear to be
> "duplicative" calls to ALIGN_TO_x_BYTES.  The second call is effectively a
> "no-op" because the bytes have already been "aligned", but does waste a
> small amount of processing power.  Looks like some additional logic in
> NDR.pm may be necessary to prevent the duplication.
Yes, i have see the same think, but no look the why...

May be ask to Mathieu (from Samba team) the creator of this patch ?
>
> Am I just missing something here?
>
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
> Archives:    http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>              mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe