Wireshark · Wireshark-dev: Re: [Wireshark-dev] Failing to push to gerrit

[Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>]

I tried with and without the trailing new line (by amending the last commit).

On Fri, Sep 5, 2014 at 7:18 PM, Pascal Quantin <pascal.quantin@xxxxxxxxx> wrote:

Le 5 sept. 2014 20:15, "Martin Mathieson" <martin.r.mathieson@xxxxxxxxxxxxxx> a écrit :

>
> Hi,
>
> Its been a while since I last pushed any changes, am now failing and don't know why.
>
> 'git review' is no longer working on this machine, I see this error:
>
> $ git review
> Traceback (most recent call last):
>   File "C:\Python27\lib\runpy.py", line 162, in _run_module_as_main
>     "__main__", fname, loader, pkg_name)
>   File "C:\Python27\lib\runpy.py", line 72, in _run_code
>     exec code in run_globals
>   File "C:\Python27\Scripts\git-review.exe\__main__.py", line 9, in <module>
>   File "C:\Python27\lib\site-packages\git_review\cmd.py", line 1132, in main
>     (os.path.split(sys.argv[0])[-1], get_version()))
>   File "C:\Python27\lib\site-packages\git_review\cmd.py", line 180, in get_version
>     provider = pkg_resources.get_provider(requirement)
>   File "C:\Python27\lib\site-packages\setuptools-0.6c11-py2.7.egg\pkg_resources.py", line 197, in get_provider
>   File "C:\Python27\lib\site-packages\setuptools-0.6c11-py2.7.egg\pkg_resources.py", line 666, in require
>   File "C:\Python27\lib\site-packages\setuptools-0.6c11-py2.7.egg\pkg_resources.py", line 565, in resolve
> pkg_resources.DistributionNotFound: git-review
>
> When I try to use push directly, it still fails, saying that there is no Change-Id: in the commit message footer.  But, my hook for adding this still works, and the commit message reads:
>
>
> $ git log -1
> commit d0bb3fe405e7a3b7d10f69109b968af6a296bb02
> Author: Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>
> Date:   Fri Sep 5 18:57:46 2014 +0100
>
>     When showing whether interfreq measurements need gaps or not, remember and show the serving and target bands for each entry
>
>     Change-Id:  Ie60dc73e40a2ac1d80197fa712075ccff83cf797
>
> I did try amending the last commit to fiddle with it a bit, but still no joy.
>
> Any ideas?
> Martin
>

Hi Martin,
No trailing new line after the Change-Id one?

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe