Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] master d04ec41: Use FreeRADIUS's warning
I still get warnings-turned-errors when building with cmake with this change:
../../asn1/kerberos/packet-kerberos-template.c:299:9: error:
'krb5_init_context' is deprecated: use GSS.framework
[-Werror,-Wdeprecated-declarations]
Is there anything I need to tweak in the cmake files somewhere?
On Wed, Aug 27, 2014 at 5:17 PM, Wireshark code review
<code-review-do-not-reply@xxxxxxxxxxxxx> wrote:
> URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d04ec412d608deb4112d11f495f7efc3070348f7
> Submitter: Guy Harris (guy@xxxxxxxxxxxx)
> Changed: branch: master
> Repository: wireshark
>
> Commits:
>
> d04ec41 by Guy Harris (guy@xxxxxxxxxxxx):
>
> Use FreeRADIUS's warning pragma controls to suppress Apple complaints.
>
> Apple would really rather that you use their Shiny Happy Frameworks
> rather than those crufty old cross-platform APIs. We are a
> cross-platform program, and will use platform-specific APIs only if
> there's enough benefit to doing so - and, in this case, that means
> "using the platform-specific APIs on OS X and the other APIs on other
> platforms", so that's two code paths to maintain, so "enough benefit"
> has to outweigh the issues with that.
>
> Change-Id: I370ba469a6f5892143d72179d15c9fe22d664fdf
> Reviewed-on: https://code.wireshark.org/review/3881
> Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
>
>
> Actions performed:
>
> from 1b3bc9b checkhf.pl: (Trivial) remove trailing whitespace.
> adds d04ec41 Use FreeRADIUS's warning pragma controls to suppress Apple complaints.
>
>
> Summary of changes:
> asn1/kerberos/packet-kerberos-template.c | 6 ++
> wsutil/Makefile.common | 1 +
> wsutil/ws_diag_control.h | 96 ++++++++++++++++++++++++++++++
> 3 files changed, 103 insertions(+)
> create mode 100644 wsutil/ws_diag_control.h
> ___________________________________________________________________________
> Sent via: Wireshark-commits mailing list <wireshark-commits@xxxxxxxxxxxxx>
> Archives: http://www.wireshark.org/lists/wireshark-commits
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
> mailto:wireshark-commits-request@xxxxxxxxxxxxx?subject=unsubscribe
