Wireshark · Wireshark-dev: Re: [Wireshark-dev] Adding a new dissector - beginners guide

[mmann78@xxxxxxxxxxxx]

The "Reply 'Done'" Button can be used by the developer making the changes, but it doesn't have to be.   There just needs to be some indication that it's been addressed ("Reply Done" or a comment posted after another patch is uploaded is fine) to make the next review go faster.  In this particular dissector's case, there were some "systematic" issues, which generated a large number of comments trying to point each instance out.  For those, I don't think you need to do a "Reply Done" for each, a comment noting the "systematic change" after you update another patch is fine.  For more of the "individual issues", you can use "Reply Done" or just make a general statement like "I believe all comments have been addressed".  If you disagree or have questions on a particular comment, a "conversation" can be had with subsequent comments (that's usually easier than using the "general" comments section when talking about an issue.

 

Michael

 

 

-----Original Message-----
From: Thomas Wiens <th.wiens@xxxxxx>
To: wireshark-dev <wireshark-dev@xxxxxxxxxxxxx>
Sent: Sat, Aug 23, 2014 11:39 am
Subject: Re: [Wireshark-dev] Adding a new dissector - beginners guide

On 22 August 2014 16:44, Bill Meier wrote:

> 
> See my comment to you on the new patch
> 
> https://code.wireshark.org/review/#/c/3794/
> 

I've got a question to the "Reply 'Done'" Button in gerrit.
Should I use it when I think I've fixed what's mentioned in the comment,
or is/should it done by the one who has entered the comment?

Is it possible to look back into another gerrit "new dissector" process
like mine? Maybe I can take a look how the normal workflow looks like,
and I don't have to ask so many questions.

-- 
Thomas

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe