Wireshark · Wireshark-dev: Re: [Wireshark-dev] Petri-Dish +1 gives an error: needs code review

[mmann78@xxxxxxxxxxxx]

I thought we intentionally wanted a (core?) developer to bless the patch (with +1) before we sent it to the Petri-Dish.  No sense in testing for compile errors if someone doesn't at least like the idea of the patch.   This may dilute the meaning of +1 review a little, but we also didn't necessarily want to waste the Petri-Dish's time either.

 

 

 

-----Original Message-----
From: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
To: Developer support list for Wireshark <wireshark-dev@xxxxxxxxxxxxx>
Sent: Fri, Aug 15, 2014 3:19 pm
Subject: [Wireshark-dev] Petri-Dish +1 gives an error: needs code review

Hi folks,

One thing I've noticed about the Petri-Dish flag in Gerrit is that every 
time I set it to +1 I get an error saying "needs code review."  Since 
Chris just noticed and complained about that too (on change 3624) I 
thought I'd mention it here.

Regards,
-Jeff
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe