Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] master 3b72a7d: Add some issues that cam
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Wed, 6 Aug 2014 00:31:31 +0200
On Sun, Aug 03, 2014 at 08:13:52PM +0000, Wireshark code review wrote:
> URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3b72a7d9767578f6be78609d0cacc34254af75b3
> Submitter: Guy Harris (guy@xxxxxxxxxxxx)
> Changed: branch: master
> Repository: wireshark
> 
> Commits:
> 
> 3b72a7d by Guy Harris (guy@xxxxxxxxxxxx):
> 
>     Add some issues that came up when comparing autotools and CMake compile flags.
>     
>     Also be consistent about whether OS X is working or not, and note that
>     we're also doing CMake builds on Solaris.
>     
>     Change-Id: I2da18d2fb5aec7e5806dc7ea186f729acef94272
>     Reviewed-on: https://code.wireshark.org/review/3389
>     Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>

Wrt GDK_DISABLE_ and GTK stuff: It's in ui/gtk/ :

jmayer@egg:~/work/wireshark/git/ui/gtk(master)> grep GDK_DISABLE_ *
CMakeLists.txt:         -DGDK_DISABLE_DEPRECATION_WARNINGS
CMakeLists.txt:         # -DGDK_DISABLE_DEPRECATED

They should mirror those of autotools. If not then yes, that should be
fixed.

ciao
     Jörg
-- 
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.