Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] master b6d20a2: Optimize reseting epan_dissect_t when filter

[Evan Huus <eapache@xxxxxxxxx>]

Another possible improvement, rather than g_mallocing the elements in the hash table, we could put them in the pinfo pool, which is always freed when proto_tree_reset or proto_tree_free are called...

On Thu, Jun 19, 2014 at 4:33 PM, Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx> wrote:

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b6d20a27a149c1b09f17561f972d0f45a41de992
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b6d20a2 by Jakub Zawadzki (darkjames@xxxxxxxxxxxx):

    Optimize reseting epan_dissect_t when filtering.

    Don't destroy interesting_hfids hash table, just remove all values.

    Change-Id: I119aaebf91aca8916aea0f15376ff2cb9d3fbc35
    Reviewed-on: https://code.wireshark.org/review/2467
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>


Actions performed:

    from  db0e534   Changed a cast (from guint to guint64) in a call to gtk_tree_store_set().  The data is actually 64-bit, and was being fetched that way - but not stored that way - leading to some very strange (and large) values.
    adds  b6d20a2   Optimize reseting epan_dissect_t when filtering.


Summary of changes:
 epan/proto.c |   16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)
___________________________________________________________________________
Sent via:    Wireshark-commits mailing list <wireshark-commits@xxxxxxxxxxxxx>
Archives:    http://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
             mailto:wireshark-commits-request@xxxxxxxxxxxxx?subject=unsubscribe