Wireshark-dev: Re: [Wireshark-dev] [PATCH] reduce scope of and close a file descriptor in wsuti
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx>
Date: Mon, 9 Jun 2014 22:43:16 +0200
On Mon, Jun 09, 2014 at 07:32:49PM +0200, Toralf Förster wrote:
> spotted by cppcheck
> 
> Signed-off-by: Toralf Förster <toralf.foerster@xxxxxx>
> ---
>  wsutil/sha1.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/wsutil/sha1.c b/wsutil/sha1.c
> index fcafd2b..081881a 100644
> --- a/wsutil/sha1.c
> +++ b/wsutil/sha1.c
> @@ -426,6 +427,8 @@ int main( int argc, char *argv[] )
>          {
>              sha1_update( &ctx, buf, i );
>          }
> +        
> +        ws_close(f);

           ^^^ fclose(f) ?

ws_close() seems to be taking file descriptor.

Cheers,
Jakub.