In valgrind script:
d) COMMAND=dumpcap
COMMAND_ARGS="-i eth1 -a duration:10"
In dumpcap.c
} else {
#if defined(DEBUG_DUMPCAP) || defined(DEBUG_CHILD_DUMPCAP)
g_log(LOG_DOMAIN_CAPTURE_CHILD, G_LOG_LEVEL_INFO,
"Wrote a packet of length %d captured on interface %u.",
phdr->caplen, pcap_opts->interface_id);
#endif
global_ld.packet_count++;
pcap_opts->received++;
/* if the user told us to stop after x packets, do we already have enough? */
if ((global_ld.packet_max > 0) && (global_ld.packet_count >= global_ld.packet_max)) {
global_ld.go = FALSE;
}
Result:
==18560== Callgrind, a call-graph generating cache profiler
==18560== Copyright (C) 2002-2012, and GNU GPL'd, by Josef Weidendorfer et al.
==18560== Using Valgrind-3.8.1 and LibVEX; rerun with -h for copyright info
==18560== Command: /home/ericsson/wireshark/.libs/lt-dumpcap -i eth1 -a duration:10
==18560==
==18560== For interactive control, run 'callgrind_control -h'.
Capturing on 'eth1'
File: /tmp/wireshark_pcapng_eth1_20140508183539_dgwcQ9
Packets captured: 2844
Packets received/dropped on interface 'eth1': 2844/0 (pcap:0/dumpcap:0/flushed:0/ps_ifdrop:4) (100.0%)
==18560==
==18560== Events : Ir
==18560== Collected : 4189109
==18560==
==18560== I refs: 4,189,109
From: wireshark-dev-bounces@xxxxxxxxxxxxx [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx]
On Behalf Of Anders Broman
Sent: den 8 maj 2014 18:32
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] Profiled dumpcap
Hi,
Yes I just started to look at this myself and was surprised to see g_log() one should have expected that if no log handler was connected there be no cost of
the operation…
Regards
Anders
From:
wireshark-dev-bounces@xxxxxxxxxxxxx [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx]
On Behalf Of Evan Huus
Sent: den 8 maj 2014 18:24
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] Profiled dumpcap
I assume that there was no other output (no logging or anything)? On my reading of the dump, most of the time is spent manipulating strings due to logging from the g_log function. The main caller seems to be
capture_loop_write_packet_cb, so removing the logging call at dumpcap.c:4051 might be worth trying.
Evan
