Wireshark-dev: Re: [Wireshark-dev] Gerrit versus Buildbot
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Bálint Réczey <balint@xxxxxxxxxxxxxxx>
Date: Fri, 21 Mar 2014 20:24:34 -0100
Hi,

2014-03-20 23:11 GMT-01:00 Guy Harris <guy@xxxxxxxxxxxx>:
>
> On Mar 20, 2014, at 2:24 PM, Chris Kilgour <techie@xxxxxxxxxxxxxxx> wrote:
>
>> On 03/20/2014 01:07 PM, Gerald Combs wrote:
>>>
>>> If the build system had open access what would keep someone from
>>> uploading a shell script containing a box full of weasels wearing clown
>>> shoes?
>>
>> Isn't the same thing true for Jenkins/buildbot spawned from gerrit?  Surely the build machines must be limited/sandboxed to prevent the circus from taking over the town.
>
> Currently, it's limited to building stuff to which at least one core developer is willing to give +2.  That requires human judgement, so it's not as rigid as a hardware/software-implemented sandbox.
Could it please be changed to build changes having at least _+1_ from
a Core Developer? +2 has the meaning that it is ready for submitting
and using +1 for triggering build-bot would be handy.

Cheers,
Balint