Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] master 579e7e1: Wireshark: Add option to choose format type

[Hadriel Kaplan <hadriel.kaplan@xxxxxxxxxx>]

Actually it's more like the 'short_name' field in that file_type_subtybe struct, but not exactly - the open_info ones are captialized whereas the file_type_subtybe 'short_name' ones are lower-case.

But in my opinion they should be not only the same exact name strings, but inside just one common struct too.

-hadriel


On Mar 6, 2014, at 10:05 AM, Anders Broman <anders.broman@xxxxxxxxxxxx> wrote:

> Thanks, so that’s the same as
> struct file_type_subtype_info {
>     /* the file type name */
>     /* should be NULL for all "pseudo" types that are only internally used and not read/writeable */
>     const char *name;
>  
> shouldn’t hurt to put those clarifications in the file :-))
>