Wireshark · Wireshark-dev: Re: [Wireshark-dev] Gerrit Topic Names

[Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>]

On Thu, Jan 30, 2014 at 3:31 PM, Bálint Réczey <balint@xxxxxxxxxxxxxxx> wrote:

Please don't list bugs in topic names, reserve the fist line for the
short summary.
Listing bugs at the end of the commit message like below is a better
practice and also helps processing the commit messages with standard
tools.

https://wiki.openstack.org/wiki/GitCommitMessages :
"The 'bug' line can reference a bug in a few ways. Gerrit creates a
link to the bug when viewing the patch on review.openstack.org so that
reviewers can quickly access the bug on Launchpad.

Closes-Bug: #1234567 -- use 'Closes-Bug' if the commit is intended to
fully fix and close the bug being referenced.
Partial-Bug: #1234567 -- use 'Partial-Bug' if the commit is only a
partial fix and more work is needed.
Related-Bug: #1234567 -- use 'Related-Bug' if the commit is merely
related to the referenced bug."

Thanks for this information, may be add to Wireshark wiki ?

 

Cheers,
Balint

2014-01-30 Anders Broman <anders.broman@xxxxxxxxxxxx>:

> Hi,
> I vote for
> - hyphens (bug-xxxx)
> Regards
> Anders
>
> -----Original Message-----
> From: wireshark-dev-bounces@xxxxxxxxxxxxx [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Evan Huus
> Sent: den 30 januari 2014 14:50
> To: Wireshark Developer List
> Subject: [Wireshark-dev] Gerrit Topic Names
>
> There are currently a couple of different formats people have been using for Gerrit topic names.
>
> - spaces (bug xxxx)
> - hyphens (bug-xxxx)
> - slashes (bug/xxxx)
>
> I don't have a particular preference, but we should probably settle on one to use consistently. The "git review" helper script I'm trying out chokes on spaces, so I'd vote against that one, but otherwise I don't see a particular reason for one or another.
>
> Thoughts?
>
> Evan
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
> Archives:    http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>              mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
> Archives:    http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>              mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe