Wireshark-dev: Re: [Wireshark-dev] tvb_get_string_enc() doesn't always return valid UTF-8
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Evan Huus <eapache@xxxxxxxxx>
Date: Mon, 20 Jan 2014 19:18:05 -0500
On Mon, Jan 20, 2014 at 6:28 PM, Guy Harris <guy@xxxxxxxxxxxx> wrote:
>
> On Jan 20, 2014, at 9:22 AM, Martin Kaiser <lists@xxxxxxxxx> wrote:
>
>> Comments in the code suggest that tvb_get_string() should replace
>> chars>=0x80 with the unicode replacement char, which is two bytes long.
>
> We should also probably audit all calls to tvb_get_string() and tvb_get_stringz() in dissectors and change them to tvb_get_string_enc() with the appropriate encoding.

Add them to checkAPIs as deprecated then, so we avoid adding any new
calls to them?