Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 53435: / /trunk/ui/gtk/: main.c /tru
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Wed, 20 Nov 2013 14:39:18 -0800
On Nov 20, 2013, at 4:04 AM, Anders Broman <anders.broman@xxxxxxxxxxxx> wrote:

> In persfilepath_opt.h
> WS_DLL_PUBLIC gboolean persfilepath_opt(int opt, const char *optstr); does not seem to work on windows where as
> extern gboolean persfilepath_opt(int opt, const char *optstr); does...

Yes - libui isn't a dynamic library, so the WS_DLL_PUBLIC isn't necessary and, as noted, doesn't appear to work.

I've checked in a fix.

> in main.c 
> 2155  int                  status;
> Should be inside #ifdef HAVE_LIBPCAP I think.

Yes.  I've checked in a fix.