Hello,
Regarding naming: As long as there is command like tvb_get_ntoh24 [40,
48, 54 and 64] (see also tvbuff.h) I will prefer to using number of
bits in the rest of commands.
By the way Jakub, what is size of "ll" on 16,32 and 64 bit
architecture? Is there any specification ensure that it cannot be
bigger than 64 bit?
On 17 November 2013 14:29, Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx> wrote:
> Hello,
>
> Right now we have the similar set of macros inside wtap-int.h & pint.h.
> I'd like to merge wtap-int.h macros to pint.h
>
> The main difference is in naming of 64-bits version.
>
> In pint.h it ends with 64 (pntoh64, pletoh64) in wtap it ends with ll
> (pntohll, pletohll, phtonll, phtolell, htolell)
>
> Which one we prefer? To be honest I'm bigger fan of 'll'.
>
> If we want to use '64' I think it'd be also good to rename
> s[hort] and l[ong] version to match convention:
>
> pntohs -> pntoh16
> pntohl -> pntoh32
> ...
> htoles -> htole16
> htolel -> htole32
>
> Cheers,
> Kuba.
> ___________________________________________________________________________
> Sent via: Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
> Archives: http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
> mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
--
Pozdrawiam / Best regards
-------------------------------------------------------------------------------------------------------------
Michał Łabędzki, Software Engineer
Tieto Corporation
Product Development Services
http://www.tieto.com / http://www.tieto.pl
---
ASCII: Michal Labedzki
location: Swobodna 1 Street, 50-088 Wrocław, Poland
room: 5.01 (desk next to 5.08)
---
Please note: The information contained in this message may be legally
privileged and confidential and protected from disclosure. If the
reader of this message is not the intended recipient, you are hereby
notified that any unauthorised use, distribution or copying of this
communication is strictly prohibited. If you have received this
communication in error, please notify us immediately by replying to
the message and deleting it from your computer. Thank You.
---
Please consider the environment before printing this e-mail.
---
Tieto Poland spółka z ograniczoną odpowiedzialnością z siedzibą w
Szczecinie, ul. Malczewskiego 26. Zarejestrowana w Sądzie Rejonowym
Szczecin-Centrum w Szczecinie, XIII Wydział Gospodarczy Krajowego
Rejestru Sądowego pod numerem 0000124858. NIP: 8542085557. REGON:
812023656. Kapitał zakładowy: 4 271500 PLN
