Wireshark · Wireshark-dev: [Wireshark-dev] FW: [Wireshark-commits] rev 52730: /trunk/epan/dissectors/ /trunk/epan/dissectors/:

[Anders Broman <anders.broman@xxxxxxxxxxxx>]

Hi,
>Anders, this may be related to your recent TVB optimizations, since I don't  think it happened before that? Did you change the behaviour of >tvb_find_line_end  or its callees at all?

Not intentionally ;-) 
I just expanded some code inside the function and used tvb_pbrk_guint8_within_tvb() to avoid a repeated call to check_offset_length()

But I may have missed something...
Regards
Anders

-----Original Message-----
From: wireshark-commits-bounces@xxxxxxxxxxxxx [mailto:wireshark-commits-bounces@xxxxxxxxxxxxx] On Behalf Of eapache@xxxxxxxxxxxxx
Sent: den 21 oktober 2013 15:07
To: wireshark-commits@xxxxxxxxxxxxx
Subject: [Wireshark-commits] rev 52730: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-cdp.c

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=52730

User: eapache
Date: 2013/10/21 01:07 PM

Log:
 Don't go into a loop if we find a zero-length line. Fixes
 https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9312
 
 Anders, this may be related to your recent TVB optimizations, since I don't  think it happened before that? Did you change the behaviour of tvb_find_line_end  or its callees at all?

Directory: /trunk/epan/dissectors/
  Changes    Path            Action
  +1 -0      packet-cdp.c    Modified

___________________________________________________________________________
Sent via:    Wireshark-commits mailing list <wireshark-commits@xxxxxxxxxxxxx>
Archives:    http://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
             mailto:wireshark-commits-request@xxxxxxxxxxxxx?subject=unsubscribe