Wireshark-dev: Re: [Wireshark-dev] follow_stream_dialog.cpp warning turning error
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
Date: Tue, 15 Oct 2013 15:04:44 -0400
On 10/15/13 11:24, Gerald Combs wrote:

On 10/14/13 10:18 PM, Joerg Mayer wrote:

[ 71%] Building CXX object ui/qt/CMakeFiles/qtui.dir/follow_stream_dialog.cpp.o
/home/jmayer/work/wireshark/svn/trunk/ui/qt/follow_stream_dialog.cpp: In member function ‘virtual void FollowStreamDialog::keyPressEvent(QKeyEvent*)’:
/home/jmayer/work/wireshark/svn/trunk/ui/qt/follow_stream_dialog.cpp:519:65: error: suggest parentheses around ‘&&’ within ‘||’ [-Werror=parentheses]
      if (event->key() == Qt::Key_F3 || event->key() == Qt::Key_N && event->modifiers() & Qt::ControlModifier) {
                                                                  ^
cc1plus: all warnings being treated as errors
make[2]: *** [ui/qt/CMakeFiles/qtui.dir/follow_stream_dialog.cpp.o] Error 1
make[1]: *** [ui/qt/CMakeFiles/qtui.dir/all] Error 2


Fixed in r52620.
I'm still getting the warning (which, in autofoo, is not translated to an error--shouldn't it be?).