Wireshark-dev: Re: [Wireshark-dev] Proper private_data usage
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Christopher Maynard <Christopher.Maynard@xxxxxxxxx>
Date: Tue, 15 Oct 2013 17:11:36 +0000 (UTC)
Jeff Morriss <jeff.morriss.ws@...> writes:

> But, yes, I think that when using private_data the restoration is 
> necessary: otherwise if you have multiple PDUs in one frame then an 
> exception in one of the early PDUs will cause the private_data to be 
> wrong when the next PDU is dissected.
> 
> This is one of the reasons not to use private_data at all.

Would it be safer and easier to maintain if this was instead done within
call_dissector() and friends?