Wireshark-dev: Re: [Wireshark-dev] Status Cmake Win32 support
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Bálint Réczey <balint@xxxxxxxxxxxxxxx>
Date: Tue, 15 Oct 2013 09:37:16 +0200
2013/10/12 Bálint Réczey <balint@xxxxxxxxxxxxxxx>:
> Hi Jörg,
>
> 2013/10/11 Joerg Mayer <jmayer@xxxxxxxxx>:
...
>> - abi check: Move abi check operation into a UseABICheck.cmake file and
>>   call that from CMakeLists. Then make it work on Win32 in a single place.
> I think it is obsolete on Windows but refactoring it makes sense.
>
> ...
>> @Balint: Would you be willing to do the abi check cleanup stuff?
> Sure.
Committed in r52614. I have extracted the common parts of ABI checks,
but did not provide a single macro since
it would add a lot of complexity for little gain, I think.

Cheers,
Balint