Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 52578: /trunk/epan/ /trunk/epan/: pr
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Pascal Quantin <pascal.quantin@xxxxxxxxx>
Date: Mon, 14 Oct 2013 10:41:08 +0200
2013/10/14 didier <dgautheron@xxxxxxxx>
Hi,
Le dimanche 13 octobre 2013 à 16:43 -0400, Evan Huus a écrit :
> On Sun, Oct 13, 2013 at 3:54 AM, Jakub Zawadzki
> <darkjames-ws@xxxxxxxxxxxx> wrote:
> > About tvb_offset_exists() comment, compute_offset() is not returning
> > exception when offset == tvb->length.
>
> Ah, OK. Should it? When offset == tvb->length I would think that
> should be an exception, since no bytes exist at that location. There
> are other places that call compute_offset and don't check the == case
> that maybe should...
On the other hand is doing parsing with tree NULL and flags.visited
false or colinfo not null worth it? There's so many bugs, Personally I
gave up on it.

One example with tshark, without a tree tcp flags aren't set anymore in
colinfo (cf packet-tcp.c around line 4228, since
dfa2156e301539929a12dda54752c778c3ee7a39 remove 'check_colinfo')
and so on...

Hi Didier,

this is fixed in r52597. If you spotted other regressions, please notify us.

Thanks!
Pascal.