Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 52484: /trunk/ /trunk/docbook/: CMak
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Bálint Réczey <balint@xxxxxxxxxxxxxxx>
Date: Thu, 10 Oct 2013 10:57:15 +0200
Hi,

2013/10/10 Joerg Mayer <jmayer@xxxxxxxxx>:
> On Thu, Oct 10, 2013 at 05:02:51AM +0000, rbalint@xxxxxxxxxxxxx wrote:
>> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=52484
>>
>> User: rbalint
>> Date: 2013/10/10 05:02 AM
>>
>> Log:
>>  Fix using fop from CMake
>
> Last time I tried (~1 week ago), this worked fine.
> What problem does this fix?
CMake did not use the found fop for me and I thought it was due to
macro expansion.
Since I can not reproduce it now on my system even with the old code I
suspect it was
related to some cache of CMake I forgot to clean after enabling
building the user guides and installing fop.

I have reverted the commit since the old code was simpler.

BTW I think the question in XML2PDF macro
    # FIXME: How do I extract the first element of a variable containing a
    # list of values? Isn't there a "cleaner" solution?
    # Oh, and I have no idea why I can't directly use _source instead of
    # having to introduce _tmpsource.
    FOREACH(_tmpsource ${${_xmlsources}})
        set(_source ${_tmpsource})
        BREAK()
    ENDFOREACH()
is answered here:
http://stackoverflow.com/questions/5248749/passing-a-list-to-a-cmake-macro

Thanks,
Balint