Wireshark-dev: Re: [Wireshark-dev] Wireshark PIDL generated dissectors
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Mon, 7 Oct 2013 22:32:20 -0700
On Oct 7, 2013, at 4:34 PM, Joerg Mayer <jmayer@xxxxxxxxx> wrote:

> IMO, the Samba team has done a rather good job maintaining the pidl source
> (including the wireshark backend) - we just did a not make very good use
> of it :-( I also think that the maintainership of the pidl sources including
> the Wireshark backend is in good hands where is currently is. We "only" need
> to get back to synching the sources and to some lesser extent the idl files.
> What we should do is:
> Determine whether our pidl (tool) sources contain any changes not upstreamed.
> Create patches against current samba pidl, get it working again and get them
> upstreamed.
> Replace our pidl tree with samba's tree (+idl_types.h).
> Regularly copy over the changes from the samba tree.

And change the Wireshark backend as we deem it proper in the future, and push those changes upstream.

Without that last part, I'd vote no.