Wireshark · Wireshark-dev: Re: [Wireshark-dev] Tool Ownership and Licensing

[Guy Harris <guy@xxxxxxxxxxxx>]

On Sep 14, 2013, at 2:27 AM, Anders Broman <a.broman@xxxxxxxxxxxx> wrote:

> Jeff Morriss skrev 2013-09-13 23:12:
>> tools/make-tap-reg.py
>> 
>> Anders Broman
>> 
> I don't remember writing this

	http://anonsvn.wireshark.org/viewvc?revision=27489&view=revision

The log message was

	Replace the clists with gtk_list_store
	Should fix bug https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3246

which doesn't seem to have anything to do with the script - did you write it to speed up builds (especially on Windows - getting rid of repeated CreateProcess() calls on Windows, as they're costlier than {v}fork()+exec on UN*X:

	r2873 | gram | 2001-01-10 23:21:35 -0800 (Wed, 10 Jan 2001) | 8 lines

	Add a python script which has the same functionality as the shell
	script 'make-reg-dotc'. It is used only in the Win32 build because the
	make-reg-dotc shell script is *so* sloooooooooow on Win32, due to the
	multiple processes (grep, grep, sed) launched multiple times for each
	source file. By putting all the text-mangling logic into a single Python
	script, only one process is launched, and the source files are read
	only once. It's *a lot* faster... seconds instead of minutes.

was the reason the Python make-register script was written) and check it in accidentally as part of that commit?

> if I did it's a copy of the make-register script, I have no problem with having
> GPL2 copyright notice added.

If Gilbert's OK with GPLv2ing make-dissector-reg.py, then we might as well GPLv2 make-tap-reg.py as well.