Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 51337: /trunk/epan/dissectors/ /trun
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
Date: Tue, 13 Aug 2013 16:10:50 -0400
On 08/13/13 07:37, mmann@xxxxxxxxxxxxx wrote:

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=51337

User: mmann
Date: 2013/08/13 04:37 AM

Log:
  Some improvements to the bundle protocol:
  1. Cleanly break out Convergence Layer Protocol (TCPCL) into its own (new-style) pure dissector.
  2. Make Bundle dissection into a new style dissector and clean so that it can be called using call_disssector.
  3. Use tcp_dissect_pdus for TCPCL protocol instead of "manual" while loop.  This allows contact header to benefit from TCP fragmentation.
  4. Make time fields use time field types so they can be filterable.
  5. A few functions were move to remove need for static declaration at top of file.
  6. Remove pri_hdr_procflags global variable.

  Next up - making more fields filterable.


This change doesn't compile with warnings turned on:


../../../epan/dissectors/packet-dtn.c: In function 'dissect_payload_header':
../../../epan/dissectors/packet-dtn.c:1260:17: error: variable 'header_start' set but not used [-Werror=unused-but-set-variable]
../../../epan/dissectors/packet-dtn.c: In function 'dissect_bundle':
../../../epan/dissectors/packet-dtn.c:2259:17: error: variable 'bundle_tree' set but not used [-Werror=unused-but-set-variable]
cc1: all warnings being treated as errors
The first one is a simple removal but I can't immediately tell whether the now-unused tree should be used or not.