Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 50967: /trunk/epan/ /trunk/epan/: proto.c

[Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx>]

Hi,

On Sun, Jul 28, 2013 at 08:33:49AM -0400, Evan Huus wrote:
> I was poking through this change and I noticed that all three places
> that call proto_unregister_field (which is very inefficient at the
> moment, possibly traversing the entire linked list twice) do so in a
> loop for all their hfs, 

AFAIK they're doing proto_unregister_field() on user-defined fields, so
just a continuous subset.

> so I was wondering if it makes sense to
> replace it with a proto_unregister_all_fields that just removes the
> whole list? I'm not sure if we want to leave proto_unregister_field
> around or not in case somebody actually needs it in the future - the
> data structures aren't really designed for that operation.

Just to note: I still plan to commit patch from:
http://www.wireshark.org/lists/wireshark-dev/201307/msg00039.html
saving 2 MB is nice (even if it's small fraction...)

Cheers,
Jakub.