Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 50939: /trunk/epan/ /trunk/epan/: pr
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Evan Huus <eapache@xxxxxxxxx>
Date: Fri, 26 Jul 2013 19:13:20 -0400
On Fri, Jul 26, 2013 at 7:01 PM, Guy Harris <guy@xxxxxxxxxxxx> wrote:
>
> On Jul 26, 2013, at 3:52 PM, eapache@xxxxxxxxxxxxx wrote:
>
>> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=50939
>>
>> User: eapache
>> Date: 2013/07/26 03:52 PM
>>
>> Log:
>> Squelch MSVC warnings. It doesn't know that DISSECTOR_ASSERT_NOT_REACHED doesn't
>> return.
>
> Is that because it doesn't know that abort() doesn't return?  It *should* know that except_throw() doesn't return; if it also knows that abort() doesn't return, maybe it doesn't realize that nothing following
>
>         (condition) ? function_that_never_returns() : another_function_that_never_returns()
>
> will be executed.

I'm not sure - the error just complained of the function not returning
in all paths.