Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 50846: /trunk/echld/ /trunk/echld/:
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Tue, 23 Jul 2013 22:48:17 +0200
On Tue, Jul 23, 2013 at 06:26:38PM +0000, lego@xxxxxxxxxxxxx wrote:
> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=50846
> 
> User: lego
> Date: 2013/07/23 11:26 AM
> 
> Log:
>  Yet another iteration...
> 
> Directory: /trunk/echld/
>   Changes    Path               Action
>   +1 -0      Makefile.common    Modified
>   +0 -1      child.c            Modified
>   +3 -0      common.c           Modified
>   +18 -9     dispatcher.c       Modified
>   +21 -4     echld.h            Modified
>   +113 -18   parent.c           Modified

You are reintroducing a bug that I fixed just this afternoon:
ECHLD_TIMEOUT is a status code but you are switching on message types.
The message type is called ECHLD_TIMED_OUT. I have only fixed that in
the code but left one incorrect comment in echld.h.

Ciao
     Jörg
-- 
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.