Wireshark-dev: Re: [Wireshark-dev] Reassembly code not working after change to use tvbuffs
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Sun, 14 Jul 2013 18:13:58 -0700
On Jul 14, 2013, at 4:37 PM, Guy Harris <guy@xxxxxxxxxxxx> wrote:

> On Jul 14, 2013, at 4:02 PM, Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx> wrote:
> 
>> Great to have some regression tests, thanks. Can you run tests on r50593?
> 
> In progress as we speak.  No errors yet.

The one-pass-dissection regression found some errors - but some were in both versions (some assertion failures in tvbuff.c when dissecting JPEGs reassembled from file chunks), and the rest were only in the *old* (pre-reassembly-using-tvbuffs) version (also in JPEGs).

So far so good.  Dissection-on-the-second-pass regression in progress.