Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 50141: / /trunk/echld/: CMakeLists.t
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Tue, 25 Jun 2013 21:24:42 +0200
Some notes about echld:

On Tue, Jun 25, 2013 at 05:43:53PM +0000, lego@xxxxxxxxxxxxx wrote:
> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=50141
> 
> User: lego
> Date: 2013/06/25 10:43 AM
> 
> Log:
>  This should get cmake to ignore echld...
> 
> Directory: /trunk/echld/
>   Changes    Path              Action
>   +80 -0     CMakeLists.txt    Added
>   +47 -32    echld_parent.c    Modified
> 
> Directory: /trunk/
>   Changes    Path            Action
>   +29 -5     Makefile.am     Modified
>   +28 -0     configure.ac    Modified
>   +2 -1      echld_test.c    Modified

Is there any reason for creating a separate echld library? It should be fine
as part of libepan.
Execept for echld.h I also see no reason to prefix the filenames with
echld_, as these files are now inside their own directroy already named echld.

Ciao
      Jörg
-- 
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.