Wireshark-dev: Re: [Wireshark-dev] [Wireshark-bugs] [Bug 6315] Info column to show subMessageId
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Anders Broman <anders.broman@xxxxxxxxxxxx>
Date: Wed, 12 Jun 2013 12:07:36 +0000
Hi,
I think I just checked the patch and applied it without too much deliberation, you can revert it if you like.
Regards
Anders


-----Original Message-----
From: Kukosa, Tomas [mailto:tomas.kukosa@xxxxxxxxxxxxxxxxxxxxxx] 
Sent: den 12 juni 2013 13:59
To: wireshark-dev@xxxxxxxxxxxxx; liam.sharp@xxxxxxxxx; Anders Broman
Subject: RE: [Wireshark-bugs] [Bug 6315] Info column to show subMessageIdentifier type strings for H245/H.239 packets

Hello Anders,

I know it is long time but do not you remember what was an intention and idea behind this patch?

It causes strange info column for H.225 protocol with H.245 inside. H.225 message type is in middle of info text:

Protocol       Info
H.225.0/H.245  masterSlaveDetermination terminalCapabilitySet CS: setup OpenLogicalChannel , Mikey: Pre-shared

How could be H.225 dissector changed to get back previous kind of output?

Protocol       Info
H.225.0/H.245  CS: setup OpenLogicalChannel masterSlaveDetermination terminalCapabilitySet, Mikey: Pre-shared

Best regards,
  Tomas


-----Original Message-----
From: wireshark-bugs-bounces@xxxxxxxxxxxxx [mailto:wireshark-bugs-bounces@xxxxxxxxxxxxx] On Behalf Of bugzilla-daemon@xxxxxxxxxxxxx
Sent: Wednesday, September 07, 2011 5:49 PM
To: wireshark-bugs@xxxxxxxxxxxxx
Subject: [Wireshark-bugs] [Bug 6315] Info column to show subMessageIdentifier type strings for H245/H.239 packets

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6315

Liam Sharp <liam.sharp@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #6938|                            |review_for_checkin?
               Flag|                            |

--- Comment #1 from Liam Sharp <liam.sharp@xxxxxxxxx> 2011-09-07 08:48:53 PDT --- Created an attachment (id=6938)  --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=6938)
Patch for review 

Change the top level messages to prepend to the column information. This allows other dissectors to add information at dissect time, rather than storing it up as per the pattern used with the OLC's. 

Update the subMessageIdentifier dissector to add extra information for h.239.