Wireshark-dev: Re: [Wireshark-dev] Filebacked-tvbuffs : GSoC'13
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Sat, 11 May 2013 10:45:33 -0700
On May 11, 2013, at 7:28 AM, Ambarisha B <b.ambarisha@xxxxxxxxx> wrote:

> I was trying to move the reassembled data from the reassembled_table to frame_data.

Moving stuff to frame_data is something that should only be done as a last resort if it's being done as part of a project to reduce memory usage. :-)

*Every packet in a capture* has a frame_data structure and, at least in one test, the memory for frame_data structures was a significant contributor to Wireshark's memory usage; overall, we want to make that structure *smaller*, not *bigger.

> The key to the reassembled_table is (framenum, ID). I am not able to figure out what ID is for. In a capture file, frame number itself would be unique, wouldn't it?

There can be more than one higher-level packet inside a frame (just as a higher-level packet can require more than one lower-level frame), so, no, the frame number is not necessarily unique.