Wireshark-dev: Re: [Wireshark-dev] Renaming some value-string API functions
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Evan Huus <eapache@xxxxxxxxx>
Date: Sat, 23 Mar 2013 09:30:43 -0400
On Sat, Mar 23, 2013 at 9:18 AM, Jaap Keuter <jaap.keuter@xxxxxxxxx> wrote:
> On 03/23/2013 01:50 PM, Evan Huus wrote:
>> On Sat, Mar 23, 2013 at 7:29 AM, Jaap Keuter <jaap.keuter@xxxxxxxxx> wrote:
>>> On 03/22/2013 09:35 PM, Evan Huus wrote:
>>>> As proposed and discussed in bug #8467. Any objections?
>>>>
>>>> https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8467
>>>
>>> Took some digging to find the rationale here:
>>> https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8461#c12
>>
>> Yes, sorry, forgot that it started on another bug.
>>
>>> Besides what's written there, don't forget about the *_ext interfaces here.
>>> Oh, and _all_ documentation / code samples, etc.
>>
>> That's what global search+replace is for :) It won't pick up wiki
>> articles but it should get README.dev and others.
>>
>>> I get the idea, but we're wondering into parser territory here. It might be a
>>> whole can-o-worms.
>>
>> Not sure what you mean? Just renaming a few functions, nothing parser-related?
>>
>
> What I mean is that you already got/may get several requests for matching functions:
> - case sensitive / non-sensitive
> - ASCII / UTF-8 / UCS-2
> - wildcards.

Ya, I (or somebody) needs to take a look at defining a scope for this
and perhaps simplifying the API. For now just having consistent names
will be a win.