Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 47774: /trunk/ui/ /trunk/ui/: software_update.c

[Gerald Combs <gerald@xxxxxxxxxxxxx>]

On 3/4/13 6:40 PM, Maynard, Chris wrote:
> In ui/gtk/main_welcome.c:welcome_new(), we have the following block of code in lines 1390-1401:
> 
> #if 0
>     /* XXX - add this, once the Windows update functionality is implemented */
>     /* topic updates */
>     topic_vb = welcome_topic_new("Updates", &topic_to_fill);
>     gtk_box_pack_start(GTK_BOX(column_vb), topic_vb, TRUE, TRUE, 0);
>     label_text =  g_strdup("<span foreground=\"black\">No updates available!</span>");
>     w = gtk_label_new(label_text);
>     gtk_label_set_markup(GTK_LABEL(w), label_text);
>     g_free (label_text);
>     gtk_box_pack_start(GTK_BOX(topic_to_fill), w, TRUE, TRUE, 0);
> #endif
> 
> Should this be added?

The WinSparkle API only lets you interactively check for updates. That
is, there's a win_sparkle_check_update_with_ui but no corresponding
win_sparkle_check_update_without_ui. I suppose for now we could change
the block above to a "Check for updates" link similar to the Help menu item.