Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 47832: /trunk/epan/dissectors/ /trunk/epan/dissectors/:

["Maynard, Chris" <Christopher.Maynard@xxxxxxxxx>]

OK, thanks for the explanation.  I was also a bit confused by the change in tree, from tr to hdr, but I assume it’s correct the way you have it now.

- Chris

 

From: wireshark-dev-bounces@xxxxxxxxxxxxx [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of mmann78@xxxxxxxxxxxx
Sent: Monday, February 25, 2013 2:09 PM
To: wireshark-dev@xxxxxxxxxxxxx
Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 47832: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-beep.c

 

There were a bunch of hfs that were boolean parameters for the existance of a specific command (where it was proto_tree_add_boolean + proto_tree_add_tree), rather than an enumeration for all commands (which is what hf_beep_cmd is).  This removed the need for hf_beep_end.

 

However, the "display flow" required that hf_beep_cmd be called "individually" for a few of the commands (including the "END" command).

 

Fix should be to just remove the assignment of ti in line 665.

 

 

-----Original Message-----
From: Maynard, Chris <Christopher.Maynard@xxxxxxxxx>
To: wireshark-dev <wireshark-dev@xxxxxxxxxxxxx>
Sent: Mon, Feb 25, 2013 12:45 pm
Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 47832: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-beep.c

Coverity CID 986569 reports an unused pointer value at line 665:

      ti = proto_tree_add_item(hdr, hf_beep_cmd, tvb, offset, 3, 

ENC_NA|ENC_ASCII);

... but looking at http://anonsvn.wireshark.org/viewvc/trunk/epan/dissectors/packet-beep.c?r1=47389&r2=47832, 

I am confused by the change made here because hf_beep_cmd is already added to 

the tree at line 616.  What happened to hf_beep_end?

I don't know, this looks wrong to me.

- Chris

-----Original Message-----

From: wireshark-commits-bounces@xxxxxxxxxxxxx [mailto:wireshark-commits-bounces@xxxxxxxxxxxxx] 

On Behalf Of mmann@xxxxxxxxxxxxx

Sent: Friday, February 22, 2013 10:48 PM

To: wireshark-commits@xxxxxxxxxxxxx

Subject: [Wireshark-commits] rev 47832: /trunk/epan/dissectors/ 

/trunk/epan/dissectors/: packet-beep.c

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=47832

User: mmann

Date: 2013/02/22 07:48 PM

Log:

 Convert proto_tree_add_text to proto_tree_add_item and expert_info.

Directory: /trunk/epan/dissectors/

  Changes    Path             Action

  +101 -185  packet-beep.c    Modified

-- 

CONFIDENTIALITY NOTICE: The information contained in this email message is intended only for use of the intended recipient. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please immediately delete it from your system and notify the sender by replying to this email.  Thank you.