Wireshark · Wireshark-dev: Re: [Wireshark-dev] Lemon on a clean build

[Gilbert Ramirez <gram@xxxxxxxxxxxxxxx>]

There was an extra dependency for the grammar.h files; I fixed this now in svn rev 47643.

The re-build of svnversion.h is still there; for some reason it wants to get built before the check, so it is in the list of targets for the initial Make process, and the final Make process in the same directory. I'll just leave it like that.

Gilbert

On Tue, Feb 12, 2013 at 9:13 AM, Gilbert Ramirez <gram@xxxxxxxxxxxxxxx> wrote:

On a "zero-touch re-build" (what I call a re-build after having changed nothing), I see these steps being performed (in different directories):

1)

  PERL     svnversion.h

2)

  LEMON    grammar.h

  CC     grammar.lo

  CCLD   libdfilter_generated.la

  CCLD   libdfilter.la

3)

  LEMON    dtd_grammar.h

  CC     dtd_grammar.lo

  CCLD   libwireshark_generated.la

  CCLD   libwireshark.la

4)

  LEMON    mate_grammar.h

  CC     mate_grammar.lo

  CCLD   mate.la

5)

  PERL     svnversion.h

(yes, once again)

6)

  CCLD   tshark

  CCLD   dftest

  CCLD   rawshark

(expected, if a few *.lo's were re-built)

If I chdir to epan/dfilter, and run a 0-touch rebuild ,twice, I see 2 different outputs:

$~/prj/wireshark-trunk/epan/dfilter$ make

  LEMON    grammar.h

$ ~/prj/wireshark-trunk/epan/dfilter$ make

  LEMON    grammar.h

  CC     grammar.lo

  CCLD   libdfilter_generated.la

  CCLD   libdfilter.la

So, yes, something is wrong with these dependencies. I'll take a look.

Gilbert

On Tue, Feb 12, 2013 at 7:58 AM, Evan Huus <eapache@xxxxxxxxx> wrote:

Sorry, so I mis-used the word 'clean' in this context.

These lines are popping up after running make twice in a row, i.e. the
first time it builds, the second time it should do nothing at all
(since nothing's changed) but it's still running lemon for some
reason.

This happens on a completely fresh checkout of trunk.

On Tue, Feb 12, 2013 at 1:26 AM, Guy Harris <guy@xxxxxxxxxxxx> wrote:
>
> On Feb 11, 2013, at 8:11 PM, Evan Huus <eapache@xxxxxxxxx> wrote:
>
>> Ever since the recent Makefile changes, running a 'clean' make (i.e.
>> no changes at all since the last build) now results in a couple of
>> calls to lemon:
>>
>> LEMON    grammar.h
>> LEMON    dtd_grammar.h
>> LEMON    mate_grammar.h
>>
>> Is this intentional? Or has it always done this, and it's just more
>> noticeable with quiet-build enabled?
>
> Well, those calls to Lemon are either bogus or mislabeled in Make's output, given that what it *should* say is something such as
>
>         LEMON   grammar.lemon
>         LEMON   dtd_grammar.lemon
>         LEMON   mate_grammar.lemon
>
> "make clean" shouldn't be removing the resulting .c or .h files, although "make distclean" should, given that we're not distributing the results of Lemon any more.
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
> Archives:    http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>              mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe