Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 46111: /trunk/epan/dissectors/ /trunk/epan/dissectors/:

[Guy Harris <guy@xxxxxxxxxxxx>]

On Nov 21, 2012, at 9:59 AM, etxrab@xxxxxxxxxxxxx wrote:

> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=46111
> 
> User: etxrab
> Date: 2012/11/21 09:59 AM
> 
> Log:
> From  l.wachowski:
> Allign the tables for dissection.
> From me try to fix the dissection of SONtransferApplicationIdentity_PDU.
> 
> https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8008
> 
> Directory: /trunk/epan/dissectors/
>  Changes    Path              Action
>  +9 -5      packet-bssgp.c    Modified

That's causing

/home/wireshark/builders/trunk/ubuntu1204x64/build/epan/dissectors/packet-bssgp.c: In function ‘de_bssgp_son_transfer_app_id’:
/home/wireshark/builders/trunk/ubuntu1204x64/build/epan/dissectors/packet-bssgp.c:3173:12: error: variable ‘next_tvb’ set but not used [-Werror=unused-but-set-variable]
cc1: all warnings being treated as errors

in the Ubuntu CMake build (I guess the automaker build isn't turning on that particular error).

The code in question is

    tvbuff_t *next_tvb;

    /* SON Transfer Application Identity: This field is encoded as the SON Transfer Application Identity IE
     * as defined in 3GPP TS 36.413
     */
    if(len > 0){
        next_tvb = tvb_new_subset(tvb, offset, len, len);
        dissect_s1ap_SONtransferApplicationIdentity_PDU(tvb, gpinfo, tree, NULL);
    }

Should it be passing next_tvb to dissect_s1ap_SONtransferApplicationIdentity_PDU()?