Wireshark-dev: Re: [Wireshark-dev] Reverting proto_tree_reset()
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx>
Date: Sat, 3 Nov 2012 22:12:42 +0100
On Wed, Oct 31, 2012 at 11:42:31AM +0100, Jakub Zawadzki wrote:
>  2/ major thing for me was to make referencing (HF_REF_TYPE_DIRECT), 
>     and unreferencing (HF_REF_TYPE_NONE) hfinfo->ref_type multi-thread dissection safe.
> 
> But achieving #2 can be done with some simpler code, rename
> dfilter_prime_proto_tree to dfilter_prime() + remove tree argument,
> and use new function after compiling dfilter and *before* dissection loops.

Actually it's not so easy, for now this is delayed ;|

> last point, r45669 is buggy, it never set hfi->ref_type back to HF_REF_TYPE_NONE.
> 
> So, I'll probably revert r45669, and fix it like I described above, 

Done in r45884, but it might require some volatile fixups.