Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 45191: /trunk/ /trunk/epan/dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Fri, 28 Sep 2012 19:33:59 +0200
On Fri, Sep 28, 2012 at 04:29:14PM +0200, Jeff Morriss wrote:
> >  Get rid of HAVE_CONFIG_H for cmake. Fix one case where it was still used.
> [...]
> >   +0 -1      CMakeLists.txt    Modified
> 
> I had been assuming that we needed to continue to define HAVE_CONFIG_H
> for backwards compatibility (e.g., for custom dissectors).  I guess
> any old dissector could/should just take it out though.  Anyway I had
> (intentionally) not removed the define (so it's still there in nmake
> and autofoo too).

Well, that way we found a missing cleanup in the main source ;-)
I'm all for removing it from the other build mothods as well, but
I don't care either way.

Ciao
     Jörg
-- 
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.