Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 44986: /trunk/ /trunk/: CMakeLists.t
From: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
Date: Tue, 18 Sep 2012 20:28:14 -0400
On 09/18/2012 06:16 PM, Gerald Combs wrote:
On 9/18/12 2:51 PM, Jeff Morriss wrote:
morriss@xxxxxxxxxxxxx wrote:
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=44986

User: morriss
Date: 2012/09/18 02:42 PM

Log:
  *NIX (autofoo and cmake) part of the fix for
  https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6134 :

  Make VERSION_MAJOR, VERSION_MINOR, and VERSION_MICRO available in
config.h so
  (e.g.) dissector writers can #if around them as necessary to make a
piece of
  code compile with different versions of Wireshark.  (Hopefully
VERSION_MICRO
  is not important in this respect!)

  Windows also defines VERSION_EXTRA which can be used to help identify
custom
  builds; this is not done for these build methods (yet?).

Gerald,

This does mean that how you bump the version in configure.ac will have
to change slightly.  If it's done by hand that's no problem (I hope ;-))
but if it's scripted then that script would need to change.

It's bumped via "make-version.pl -v". I updated make-version.pl
accordingly in r44990.

Oops, yeah, I guess I missed that.  <sigh>  Thanks for fixing it!