Wireshark · Wireshark-dev: Re: [Wireshark-dev] Disabling a dissector doesn't seem to quite work.

[Christopher Maynard <Christopher.Maynard@xxxxxxxxx>]

Evan Huus <eapache@...> writes:

> There is already a (commented-out) function called
> dissector_add_uint_sanity_check which does warn on duplicate port
> registrations and on registrations to port 0. It produces 157 warnings
> when enabled in the default build. I don't know how many duplicate
> string registrations there are, but there are definitely some based on
> valgrind's output.

I took a quick look at EIGRP since tshark was reporting these strange warnings
against itself:

** (tshark.exe:6984): WARNING **: ip.proto: eigrp registering using pattern 88
already registered by eigrp
** (tshark.exe:6984): WARNING **: ddp.type: eigrp registering using pattern 88
already registered by eigrp
** (tshark.exe:6984): WARNING **: ipx.socket: eigrp registering using pattern
34238 already registered by eigrp

Hmm, so it seems that the doxygen comments are somehow causing this?  For
example, the following patch eliminates the warnings for me:

Index: epan/dissectors/packet-eigrp.c
===================================================================
--- epan/dissectors/packet-eigrp.c      (revision 44888)
+++ epan/dissectors/packet-eigrp.c      (working copy)
@@ -3351,7 +3351,6 @@
 }

 /**
- *@fn void proto_reg_handoff_eigrp(void)
  *
  * @param[in] void
  * @param[out] None

The h450, qsig, ssl, tcap and uaudp dissectors report similar warnings against
themselves, but for other reasons.