Wireshark-dev: Re: [Wireshark-dev] Why are authors never Cc'ed before their code is changed?
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Christopher Maynard <Christopher.Maynard@xxxxxxxxx>
Date: Sun, 19 Aug 2012 23:29:20 +0000 (UTC)
Pascal Quantin <pascal.quantin@...> writes:

> 2012/8/19 Harald Welte <laforge@xxxxxxxxxxxx>
> I agree that this massive filter rename could / should have been discussed
before being done

The changes that Michael is making regarding filter renaming stems from
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2794.  Anyone is welcome to
join the discussion there.

In general, renaming filters serves to:
1) Provide a consistent naming scheme.
2) Match the doc/README.developer skeleton code documentation.
3) Avoid unintended display filter name collisions.

In addition, renaming filters has also helped to find/fix some unintentional
duplicate filter names, some of which have manifested themselves as nasty bugs.

Michael's checkfiltername.pl script aids in finding potential candidates; it is
not being globally applied.

- Chris