Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 44558: /trunk/epan/dissectors/ /trun
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Sat, 18 Aug 2012 11:12:45 -0700
On Aug 18, 2012, at 8:02 AM, mmann78@xxxxxxxxxxxx wrote:

> Burned by the ASN.1 compiler again (I'll eventually learn to double-check the top of a dissector file when looking for general improvements with dissectors).  However, I think the better fix would be to make the key session-scope_allocated as well.

Yes.  While you're at it, you might want to just use se_strdup_printf() if possible, rather than g_snprintf() into a buffer and then se_strdup() of the buffer.

> That was just an oversight on my part (apart from not modifying the template file).  I'll use this as an excuse to get better acquainted with the ASN.1 compiler and provide that fix.

Not too much familiarity is needed in this case - specialized code is either in the .cnf file or in the template file and, in this case, it's in the template file.  Edit the template file and run "make", on UN*X, or "nmake -f Makefile.nmake", on Windows, in the directory for the dissector, which would be under the top-level asn1 directory; that will re-generate the dissector source under epan/dissectors.