Wireshark · Wireshark-dev: Re: [Wireshark-dev] Make the NTLMSSP Unknown message type string more explicit

[Pascal Quantin <pascal.quantin@xxxxxxxxx>]

2012/7/14 Richard Sharpe <realrichardsharpe@xxxxxxxxx>

Hi folks,

One problem I saw at Sharkfest was that the NTLMSSP dissector was
printing UNKNOWN message type on the info field, which was being
confused as an Unknown SMB2 message type by the presenter.

This makes it more explicit:

Index: epan/dissectors/packet-ntlmssp.c
===================================================================
--- epan/dissectors/packet-ntlmssp.c    (revision 43690)
+++ epan/dissectors/packet-ntlmssp.c    (working copy)
@@ -2173,7 +2173,7 @@
     col_append_sep_fstr(pinfo->cinfo, COL_INFO, ", ","%s",
                     val_to_str(ntlmssph->type,
                                ntlmssp_message_types,
-                               "Unknown message type"));
+                               "Unknown NTLMSSP message type"));

     /* Call the appropriate dissector based on the Message Type */
     switch (ntlmssph->type) {

Hi Richard,

thanks for the suggestion: committed in revision 43713.

Regards,
Pascal.