Wireshark · Wireshark-dev: Re: [Wireshark-dev] r43579 "Generic preference implementation" broken compile

[mmann78@xxxxxxxxxxxx]

Yes, the following files can now be deleted:

 

\wireshark\ui\gtk\prefs_nameres.c

\wireshark\ui\gtk\prefs_nameres.h

\wireshark\ui\gtk\prefs_print.c

\wireshark\ui\gtk\prefs_print.h

\wireshark\ui\gtk\prefs_protocols.c

\wireshark\ui\gtk\prefs_protocols.h

\wireshark\ui\gtk\prefs_taps.c

\wireshark\ui\gtk\prefs_taps.h

 

 I thought removing them was part of the patch for bug 7402, but they still show up in the SVN (perhaps I didn't create the patch correctly).  Hopefully no one has started porting them to qt.

 

 

-----Original Message-----
From: Stephen Fisher <steve@xxxxxxxxxxxxxxxxxx>
To: Developer support list for Wireshark <wireshark-dev@xxxxxxxxxxxxx>
Sent: Fri, Jul 6, 2012 2:24 pm
Subject: Re: [Wireshark-dev] r43579 "Generic preference implementation" broken compile

---- On Fri, 06 Jul 2012 12:03:30 -0600 <mmann78@xxxxxxxxxxxx> wrote ---- 

 >  Also, prefs_nameres.c shouldn't be building anymore.  The top of the tree 
should have it removed from any makefiles (unless I screwed up the patch).  The 
functionality of prefs_nameres.c was replaced with the generic handling of 
preferences that used to be unique to only protocol preferences.
 >   

A "make clean" didn't resolve the issue, but a fresh checkout did allow it to 
compile.  If we're not using prefs_nameres.c anymore, can we delete it?

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe