Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 43176: /trunk/epan/dissectors/ /trunk/epan/dissectors/:

[Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>]

Hi Chris (and others)
I add a sample (for later regression test and buildbot...) of Supported Rates in Bug 7333 ( Attachment 8620). 

Regards,

On Sat, Jun 9, 2012 at 8:40 PM, Maynard, Chris <Christopher.Maynard@xxxxxxxxx> wrote:

It was a guess.  The attachment in the bug report, namely "wint168.txt", only revealed the following::

       This application has requested the Runtime to terminate it in an unusual way.
       Please contact the application's support team for more information.

I didn't see anything wrong with the "wlan_mgt.fixed.capabilities.dsss_ofdm" field, which was the one in which the above message appeared, so I went looking for nearby fields for potential problems, and that's when I noticed that hf_ieee80211_tag_supp_rates had "FT_UINT8, BASE_NONE", and the display filter for that field is "wlan_mgt.supported_rates", which is the last thing printed in the wint168.txt file, so I figured that was most likely the problem.

- Chris

________________________________________
From: wireshark-dev-bounces@xxxxxxxxxxxxx [wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Jeff Morriss [jeff.morriss.ws@xxxxxxxxx]
Sent: Saturday, June 09, 2012 2:26 PM
To: wireshark-dev@xxxxxxxxxxxxx
Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 43176: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-ieee80211.c

On 06/09/2012 01:08 PM, cmaynard@xxxxxxxxxxxxx wrote:
> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=43176
>
> User: cmaynard
> Date: 2012/06/09 10:08 AM
>
> Log:
>   Do not use BASE_NONE for FT_UINT8 types.
>   Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7333 (I think).

The code in epan/proto.c seems to indicate that using BASE_NONE with
FT_*INT* types should be OK when there the strings converter is supplied:

>                 case FT_UINT32:
>                 case FT_UINT64:
>                         if (hfinfo->strings == NULL) {
>                                 /*  Require integral types (other than frame number,
>                                  *  which is always displayed in decimal) to have a
>                                  *  number base */
>                                 if (hfinfo->display == BASE_NONE)
>                                         g_error("Field '%s' (%s) is an integral value (%s)"
>                                                 " without strings but is being displayed as BASE_NONE\n",
>                                                 hfinfo->name, hfinfo->abbrev,
>                                                 val_to_str(hfinfo->type, hf_types, "(Unknown: %d)"));
>                         }

Where was it crashing (er, excepting out)?  (There's no sample PCAP file
in that bug.)
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
            mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe

CONFIDENTIALITY NOTICE: The information contained in this email message is intended only for use of the intended recipient. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please immediately delete it from your system and notify the sender by replying to this email.  Thank you.

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
            mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe