Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 42578: /trunk/wiretap/ /trunk/wireta
On 5/11/12 10:26 AM, Guy Harris wrote:
>
> On May 11, 2012, at 10:15 AM, gerald@xxxxxxxxxxxxx wrote:
>
>> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=42578
>>
>> User: gerald
>> Date: 2012/05/11 10:15 AM
>>
>> Log:
>> Use "%parse-param" instead of a global variable. Fixes a scan-build
>> warning.
>
> I think that requires a newer version of Bison to compile - YACC, and older versions of Bison, and possibly Berkeley YACC may not handle that.
>
> For building from a source tarball, that won't matter if the tarball includes the result of running Bison on ascend.y.
>
> For building from SVN, it will matter. It'd be nicer if the configure script would warn about that...
>
> ...but we've already run into this issue with Flex, as I remember. I'm not sure what the right way not to require Flex or YACC/Bison (or particular versions thereof) for people just building from the source tarball as an alternative to installing a binary package but to require it for people building from SVN or doing development with a source tarball (which they probably shouldn't be doing if they can possibly just develop from SVN, but...).
According to the Bison changelog support for "%parse-param" was added in
2002 so it should be reasonable to expect it to work.
Berkeley YACC added support in mid-2010. It looks like the various BSD
YACCs don't support it except in the most recent version of NetBSD.
/usr/ccs/bin/yacc on Solaris 10 doesn't even support "-o", which we use
to specify ascend.c as the output filename so it likely never worked.
The best answer is probably something along the lines of "use Lemon to
generate ascend.c" but I'm not sure how much effort that would require.
--
Join us for Sharkfest ’12! · Wireshark® Developer and User Conference
Berkeley, CA, June 24-27 · sharkfest.wireshark.org
