Wireshark · Wireshark-dev: Re: [Wireshark-dev] Some functions not in API (function not static, not exported, no prototype in .h

[Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>]

Jakub Zawadzki wrote:
> Hi,
>
> Ubuntu buildbot[1] warns if function is not declared as static, but there's missing prototype.
>
> Most interesting ones:

My thoughts:

>   prefs.c:862: warning: no previous prototype for prefs_get_uint_preference

This isn't used anywhere and I don't see what it's useful for...  I'd 
vote to remove it for now.

>   proto.c:7747: warning: no previous prototype for proto_tree_add_bits_format_value
>   tvbuff.c:2025: warning: no previous prototype for tvb_unicode_strsize

Sure, those two make sense (to me) to include.