Wireshark · Wireshark-dev: Re: [Wireshark-dev] happy birthday, bug 5531!

[Ed Beroset <beroset@xxxxxxxxxxxxxx>]

Joerg Mayer wrote:

> I have a few small questions that came up during looking at the patch
> (not all of them relevant to this patch!):
> - why is eax.[ch] in epan instead of epan/crypt/?
> - why do we have files named crypt/crypt-aes.c instead of crypt/aes.c?
> - is eax.c added to CMakeLists.txt as well?

For what it's worth, I've addressed these and a few other things in an 
updated patch.  Thanks for the feedback!

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5531

Comments:
This patch differs from the previous in a couple of mostly minor ways, 
mostly
inspired by comment #20.  Changes are:
1. Moved eax.c and eax.h to crypt
2. fixed minor bug involving padding.  In the cases where the code 
should have
added exactly one pad byte, it was instead adding seventeen pad bytes.	
3. added eax to CMakeLists.txt
4. slightly simplified header canonization code
5. retested and refuzzed

Ed